Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(examples): add example to utilize utils #1752

Merged
merged 1 commit into from
Mar 22, 2022
Merged

docs(examples): add example to utilize utils #1752

merged 1 commit into from
Mar 22, 2022

Conversation

RonMallory
Copy link
Contributor

@RonMallory RonMallory commented Mar 17, 2022 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR provides examples on utilizing the utils.create_from_yaml and utils.create_from_directory. It also has supporting .yaml files examples.

Which issue(s) this PR fixes:

Relates #1737

Special notes for your reviewer:

The examples provide should help increase the use of utils.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

@RonMallory: The label(s) kind/docuementation cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind docuementation

What this PR does / why we need it:

This PR provides examples on utilizing the utils.create_from_yaml and utils.create_from_directory. It also has supporting .yaml files examples.

Which issue(s) this PR fixes:

Fixes #1737

Special notes for your reviewer:

The examples provide should help increase the use of utils.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2022
@RonMallory
Copy link
Contributor Author

Hi,

/assign @roycaihw

Can you please take a look at this PR.

Thank you,

Ron!

@RonMallory
Copy link
Contributor Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 19, 2022
@roycaihw
Copy link
Member

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RonMallory, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit d50c296 into kubernetes-client:master Mar 22, 2022
@sm-moore sm-moore mentioned this pull request Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RonMallory @k8s-ci-robot @roycaihw